search

oh-my-fish / theme-default

MIT License
40 stars 32 forks source link

Provide a way for the user to know they're logged as `root` #26

Open fidencio opened 2 years ago

fidencio commented 2 years ago

Currently, in case the user has decided to switch all the terminal instances they have access to to using fish with oh-my-fish, and they go for this very same theme in all instances (why not, right? this theme rocks! ;-)), they'll soon enough realise there's absolutely no indicator on whether you're running as root or not.

We should provide some differentiation, something that catches the user's attention, when they're running as root.

I'm opening the issue and not yet providing a PR as I think how we provide this is something that should be discussed first, as the default theme is quite lean and we don't necessarily want to make it too much.

@bpinto @scorphus, ideas on how to approach this one?

fidencio commented 2 years ago

This is a simple POC that I'd like you to take a look: https://asciinema.org/a/fuPchJqAGwvivPg2J11qNoSny

This POC depends on https://github.com/oh-my-fish/theme-default/pull/23 and I can submit a PR, if y'all are okay with the changes, as soon as https://github.com/oh-my-fish/theme-default/pull/23 gets merged.