Closed mon closed 1 year ago
I actually moved back to the raw calls, because it was a little cleaner to read
So maybe we shouldn't implement this? It's ok to tell users to use raw queries for some usecases 🙂
Anyway, this looks good to me, just add a few tests to make sure till it works as expected 💪
Ah, I forgot about the tests 😅
So maybe we shouldn't implement this? It's ok to tell users to use raw queries for some usecases
I'm totally happy to drop this PR in that case - I wasn't sure how much you wanted to force "never use raw" or whether it handles exciting edge cases and should be recommended often.
It really depends on your experience: if you think this is useful I'd be happy to merge this 😄
I've been nudged by a friend to land this, so I guess I will now! My tests actually stalled for over 5 minutes and I aborted, but the important ones passed
test query::tests::it_builds_correct_query ... ok
test query::tests::it_builds_correct_query_without_filters ... ok
The ones that stalled, if that's an interesting case for you:
test async_query::tests::async_it_provides_raw_query_result has been running for over 60 seconds
test de::wbem_class_de::tests::it_can_desr_newtype_enum has been running for over 60 seconds
test query::tests::con_get_return_a_raw_object_by_path_from_actual_path has been running for over 60 seconds
test query::tests::it_can_query_all_classes has been running for over 60 seconds
Closes #75
I actually moved back to the raw calls, because it was a little cleaner to read... I had to make the filters twice, once for the initial population and once more for following device changes with
__InstanceOperationEvent
. But this did work with my toy example.