search

ohadravid / wmi-rs

WMI crate for rust
Apache License 2.0
84 stars 27 forks source link

Update to windows 0.58 #98

Closed Jasper-Bekkers closed 2 months ago

Jasper-Bekkers commented 2 months ago

Not a huge change, this updates wmi-rs to windows 0.58

Jasper-Bekkers commented 2 months ago

Addressed all feedback, this should (tm) make the tests run again as well.

Jasper-Bekkers commented 2 months ago

LGTM 🎉

Would you mind spinning a release if/when this lands?

ohadravid commented 2 months ago

Oh no:

> cargo test -- --nocapture --test-threads 1 it_can_desr_newtype_enum_field
...

Caused by:
  process didn't exit successfully: `... --nocapture --test-threads 1 _enum_fi` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)
Jasper-Bekkers commented 2 months ago

My first guess would be a problem I've seen before with the implement macro but this requires a bit more investigation.

ohadravid commented 2 months ago

@Jasper-Bekkers - seems like an issue with IUnknown::from_raw, which should be the _borrowed version.

Can you merge the changes from my branch (https://github.com/ohadravid/wmi-rs/tree/update-win-0.58-fixes) into yours?

Jasper-Bekkers commented 2 months ago

@Jasper-Bekkers - seems like an issue with IUnknown::from_raw, which should be the _borrowed version.

Can you merge the changes from my branch (https://github.com/ohadravid/wmi-rs/tree/update-win-0.58-fixes) into yours?

Done - looks like it needed a cargo fmt still, so I pushed that. Thanks for taking the time to look into this.