search

ohadschn / letsencrypt-webapp-renewer

[PLEASE USE FREE MS MANAGED CERTS INSTEAD] Simple WebJob-ready console application for renewing Azure Web App SSL certificates
https://www.ohadsoft.com/
Apache License 2.0
282 stars 51 forks source link

GoDaddy DNS support #111

Open InteXX opened 4 years ago

InteXX commented 4 years ago

Could this be a way to support GoDaddy DNS?

It gets a bit tricky due to GoDaddy's lack of a delete API, but I believe that can be accommodated.

ohadschn commented 4 years ago

I'm assuming you mean support for the DNS challenge when your DNS provider is GoDaddy.

I'm not using certbot, but it seems the underlying library I'm using does have GoDaddy support (GoDaddyDnsProvider): https://github.com/sjkp/letsencrypt-azure/issues/2 - I see you spotted that issue as well.

So it should be possible, but I don't have any concrete plans to implement it any time soon...

InteXX commented 4 years ago

I don't have any concrete plans to implement it any time soon

I understand.

The solution provided in that issue seems to require a rebuild; it'd be nice to be able to effect a change at runtime, thereby permitting use of the official codebase.

ohadschn commented 4 years ago

I'm pretty sure it can be implemented without requiring a rebuild - we should be able to use GoDaddyDnsProvider instead of AzureDnsProvider depending on configuration.

One of the reasons I don't have plans to add GoDaddy DNS though is that I don't have GoDaddy DNS to test it. But if someone were to submit a PR that could work :)

I'm reopening this because it's definitely a legitimate feature request...

InteXX commented 4 years ago

I'm not at all handy with C#. Otherwise, I'd consider giving it a run.

Testing suggestion: You could register a test domain at GD and point its zone to your Azure stuff. You'd be out twenty bux, though, so that may not be desirable. (Maybe you've already got a spare that you're not using that you could transfer over.)

InteXX commented 4 years ago

Follow-up: If you decide to look into this at some point, I might be able to help by retargeting one (or more) of my parked domains for your needs.

I suppose I could even add you as a DNS admin.

ohadschn commented 4 years ago

I admit this will be a low priority, but sure if you make me an admin it might speed things up when relevant...

InteXX commented 4 years ago

Perfect. Just let me know, should ever the time come.

lpperras commented 3 years ago

Also needed it for our need so created a PR for it.

120