ohadschn / letsencrypt-webapp-renewer

[PLEASE USE FREE MS MANAGED CERTS INSTEAD] Simple WebJob-ready console application for renewing Azure Web App SSL certificates
https://www.ohadsoft.com/
Apache License 2.0
282 stars 51 forks source link

Fails on Azure German Cloud #13

Closed jessenic closed 7 years ago

jessenic commented 7 years ago

The WebJob is failing on Azure German Cloud. Is it trying to contact the general Azure portal instead of portal.microsoftazure.de?

ERROR: Encountered exception: Microsoft.IdentityModel.Clients.ActiveDirectory.AdalServiceException: AADSTS90038: Confidential Client is not supported in Cross Cloud request.

ohadschn commented 7 years ago

Could you provide the full log?

ohadschn commented 7 years ago

Interesting, it looks like I need to add support for some more parameters: https://github.com/sjkp/letsencrypt-siteextension/issues/64 https://github.com/sjkp/letsencrypt-siteextension/wiki/Azure-Germany,-US-or-China

I will try and get to it as soon as I can.

berhir commented 7 years ago

I had the same problem today. Do you have an update on the progress to support the German Azure Cloud? Thanks!

ohadschn commented 7 years ago

@berhir I'm hoping to add it tomorrow, if not then probably next week. Of course I will accept a PR too :)

ohadschn commented 6 years ago

Released 0.8.5 with this feature.