search

ohadschn / letsencrypt-webapp-renewer

[PLEASE USE FREE MS MANAGED CERTS INSTEAD] Simple WebJob-ready console application for renewing Azure Web App SSL certificates
https://www.ohadsoft.com/
Apache License 2.0
282 stars 51 forks source link

README: Added remarks about Internationalized Domain Names #89

Closed haukepribnow closed 5 years ago

haukepribnow commented 5 years ago

I just ran into a wall when trying to set up letsencrypt-webapp-renewer with a hostname that has an Internationalized Domain Name (IDN). To avoid other people running into the same wall, I'd like to propose the small addition to the README.MD as you can see in this pull request.

ohadschn commented 5 years ago

Thanks, but before I merge this, let me run some IDN tests on my end.

ohadschn commented 5 years ago
  1. I've updated the config samples to include an IDN host name. since I am delegating the config docs to https://github.com/sjkp/letsencrypt-siteextension, your general explanation would be better suited there.
  2. I've clarified the requirement for azureDnsZoneName, but note that for now I had to disable DNS challenge support due to its removal from https://github.com/sjkp/letsencrypt-siteextension.