search

ohadschn / letsencrypt-webapp-renewer

[PLEASE USE FREE MS MANAGED CERTS INSTEAD] Simple WebJob-ready console application for renewing Azure Web App SSL certificates
https://www.ohadsoft.com/
Apache License 2.0
282 stars 51 forks source link

Support DNS challenge #91

Closed ohadschn closed 4 years ago

ohadschn commented 5 years ago

Since DNS challenge support was dropped from letsencrypt.azure.core, new support must be implemented on top of https://github.com/sjkp/letsencrypt-azure.

Waiting for instructions here: https://github.com/sjkp/letsencrypt-siteextension/pull/332#event-2693400466.

rasolo commented 4 years ago

Hi @ohadschn,

I get the error "Azure DNS challenge currently not supported" when using https://github.com/ohadschn/letsencrypt-webapp-renewer, is there a different method that can be used?

I don't understand this sentence in the readme: "You may use the ACME DNS challenge instead of the HTTP challenge. Currently only Azure DNS is supported, and it can be activated using the following configuration:" It says that you can use the ACME DNS challenge, then it says only Azure DNS challenge is supported thereby stating that the previous statement is false. And the DNS challenge which i'm guessing is the Azure DNS challenge doesn't work either..

Anyway, is there a way to get it working using some other method?

Thanks

Edit:

After finally getting to the stage (using the website extension instead) of where it tried to create a lets encrypt certificate, it gave an error message that you can't create certificates for free/shared tier.

I have put my web app on basic tier now and using the free azure ssl instead. I will keep an eye on the pricing to see if it is worth it.

ohadschn commented 4 years ago

Hi, I'm afraid it's not currently supported since the underlying package I was using (letsencrypt.azure.core) dropped support with the move to ACME v2 (so you can't just use an older version since v1 has been deprecated by Let's Encrypt).

I started working on support using the new package (LetsEncrypt.Azure.Core.V2), you can check it out here: https://github.com/ohadschn/letsencrypt-webapp-renewer/tree/azure-dns.

ohadschn commented 4 years ago

Fixed in 1.0.5