search

ohaiwalt / cog-helm

A Helm chart to deploy Cog on Kubernetes
Apache License 2.0
18 stars 4 forks source link

Fix cog deployment template labels #9

Closed so0k closed 7 years ago

so0k commented 7 years ago

The cog-service defines:

selector:
    app: {{ template "cog.fullname" . }}

As such, the cog-deployment should attach correct label

spec:
  replicas: {{ .Values.cog.replicaCount }}
  template:
    metadata:
      labels:
        app: {{ template "cog.fullname" . }}
so0k commented 7 years ago

I updated the wrong label in first commit... I can revert and squash all if you want.

Overall, I think the labels currently should be structured slightly different - this PR is to fix a bug.

The bug did not manifest as the helm chart name was such that fullname and cog.fullname templates were identical as long as user did not specify .Values.nameOverride

ohaiwalt commented 7 years ago

Nice catch, thanks!