search

ohanhi / atom-highlight-bad-chars

Atom plugin: Highlight bad Unicode characters that can cause hard to spot syntax errors.
MIT License
19 stars 12 forks source link

Function.extractParams is deprecated. #7

Closed kankaristo closed 7 years ago

kankaristo commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/usr/share/atom-beta/resources/app.asar/src/text-editor.js:1753:38)
<unknown> (/home/sami/.atom/packages/highlight-bad-chars/lib/highlight-bad-chars.coffee:26:29)
<unknown> (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:950:18)
WaKeMaTTa commented 7 years ago

Please fix this.

ohanhi commented 7 years ago

I would if I knew how. There's nothing on the Atom plugin documentation on this. Why don't you give it a try and submit a PR?

WaKeMaTTa commented 7 years ago

@ohanhi Check this PR https://github.com/smashwilson/merge-conflicts/pull/265

WaKeMaTTa commented 7 years ago

I have done a PR https://github.com/ohanhi/atom-highlight-bad-chars/pull/13

ohanhi commented 7 years ago

Thanks! Published as 1.0.7