search

ohanhi / elm-native-ui

[CLOSED] Experiment: mobile apps in Elm using React Native.
BSD 3-Clause "New" or "Revised" License
1.54k stars 76 forks source link

Testing and upgrading react-native version #86

Closed jadehopepunk closed 7 years ago

jadehopepunk commented 7 years ago

I've been going through the react native version on the two examples, and upgrading it version by version. For each minor version, I've tested both examples in both Android and iOS simulators (by manually regression testing).

My goal here is obviously to get them to the current version, to demostrate that react-native-ui still works with current react and is a valid technique (I suspect it is).

However, at version 0.42.x I've hit a snag with the NavigationDemo example on Android only. The push and pop buttons no longer work. I'm going to see if I can figure out the solution to that, and will them submit further upgrades, but in the meantime this pull request at least brings things up to date as of January 2017.

Obviously the pull request itself isn't exciting, it's just version number changes, but I've spent about 5 hours of manual testing to verify that it's safe to do so, so it'd be good if other people were saved from that effort by having these version changes.

jadehopepunk commented 7 years ago

The 0.42.x problems on Android I mentioned in my initial message appear to not be present in the most up to date patch version of that release, 0.42.3. So, that upgrade has been added, and we're now up to date with February. I'll continue to push updates here, so perhaps don't merge this PR just yet.

jadehopepunk commented 7 years ago

Ok, this looks like it's as far as I can take this with simple upgrades.

The next react-native release, 0.44.3, deprecates Navigation Experimental, which is used by the navigation example here. While it's still available in another package, using that would be the wrong approach. When I get time, I'll try and port this to using React Navigation, which is now the accepted way of doing things. Until this, I'd recommend merging this PR so that people know it's straightforward to use the Elm Native UI code with react versions up to 0.43.4. If I sort out the navigation thing, I'll submit that as a seperate pull request if this has already been merged (or add it to this one if it hasn't).

ohanhi commented 7 years ago

Thank you, @craigambrose! Would you mind adding a note about the versions on the README too?

jadehopepunk commented 7 years ago

Done