Creating config.yml file for Welcome bot

[malvikasharan]

Summary

I have opened an issue #132 and adding the config file for the welcome bot

what should reviewers focus on?

• The messages in the Config file make sense
• They can test this bot on Turing Way repo by creating a new issue
• Configure the welcome bot as described in my issue
• Ask someone who hasn't already created a new issue or PR, can test if the bot works in this repo by creating an issue

[Remi-Gau]

Brilliant. I will assign some reviewers to this.

[Remi-Gau]

@cmaumet @llevitis @DorienHuijser

@malvikasharan has pretty much set up the welcome bot for us. :robot:

I think this would be a nice way to welcome project submission as issues and also first PR and merge especially on for the venue page #38.

[Remi-Gau]

@DorienHuijser Looks like you're rocking this review on github thing.

@malvikasharan don't feel like you have to make those edits. We can take it from there if you want. #WeAreAllBusy #TooBusy

[malvikasharan]

I will be happy for you all to change the file as it works best for you. It's only a draft to begin this work. I am flying away to another meeting. Do call me in if there are some errors that need fixing.

[Remi-Gau]

I will also ping the traintrack instructors to see if they want to have an input on this as the welcome bot will be really nice to have if attendees decide to do their PR for the venue page.

[KirstieJane]

Hey @DorienHuijser - I'm just going to add this here because you said you're new to this process. Please excuse me if you already know this!

In your review, you've suggested changes (README file --> README for example). Your review then "Requests changes". This workflow is totally fine. It's asking @malvikasharan to make the changes that you've suggested. In addition, the PR will be blocked until you (Dorien) have re-reviewed it.

In the conversation though, @malvikasharan has asked that you - as a member of the OHBM Hackathon community - make the changes yourself. Now, you might not have write access to do that though, so it might be that @Remi-Gau or someone who has write access to the repository needs to make those changes.

Does this make sense? Please ask if not - doing a PR review can be a little jargon-y the first time ✨

[DorienHuijser]

@KirstieJane thanks! I wasn't aware that I have to re-review it after changes have been made. Should I have chosen "comment" or "approve" instead of "request changes"? I also see the option to "Commit suggestion" for each change I suggested, would that be an alternative so that there is no re-review required and/or @malvikasharan doesn't have to make the changes themselves?

[KirstieJane]

Yes! If you can commit (and @malvikasharan has said that's ok - which she has) then go ahead and commit the changes 🚀

And yes, approve means approve, and comment means "just a comment". "Request changes" means "block this PR until I approve of the updates". I think its a super non-intuitive choice of phrasings! It's useful from GitHub from the perspective of maintainers wanting to have lots of control.... I just think its (another) barrier to learning all this stuff!

Thank you for participating!! ✨

[malvikasharan]

@DorienHuijser Thank you so much for all the edits! 🎉 They look great! I totally agree with Kirstie, there is a lot to jargons and many non-intuitive Git words. Thank you for patiently looking into this PR, you are totally nailing the GitHub PR review. 🌺

Thank you @KirstieJane for taking the time to explain this.

[DorienHuijser]

@KirstieJane thank you for explaining so patiently! :tada: @malvikasharan I approved the changes now, hopefully next time will go a bit smoother 😉

[Remi-Gau]

Thanks for all those explanations @KirstieJane. I admit that our onboarding process has been a bit "thin" given our time frame.

But @DorienHuijser you have caught up with all this super fast. :-)

I have made some additional changes linking to some other document that might be more relevant in the hackathon context. @DorienHuijser feel free to amend.

I will ask Liza for a cross-check tomorrow and then we should be ready to go.

[Remi-Gau]

Thanks @malvikasharan @KirstieJane @DorienHuijser @llevitis

:pray: :heart:

Will merge this now!

:rocket: