search

ohbm / hackathon2020

Website for the 2020 OHBM Hackathon (Location: 3rd planet from the Sun)
https://ohbm.github.io/hackathon2020/
MIT License
68 stars 68 forks source link

Add phys2bids project #209

Closed smoia closed 4 years ago

smoia commented 4 years ago

I'd like to add the project snippet for #193 . Since the project is in two hubs, how should that field be formatted?

welcome[bot] commented 4 years ago

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) :sparkling_heart: Thanks for opening this pull request! :sparkling_heart: We really appreciate your time and effort to contribute to the project. If you are trying to add your contribution to our Venue page, please make sure you have read our instructions and have shared all relevant details in your pull request. The OHBM Brainhack webteam might be a bit busy right now but we will have a look at your suggestion very quickly.

jhlegarreta commented 4 years ago

@smoia looks like the project was already added to the website: https://github.com/ohbm/hackathon2020/blob/master/_data/projects.yml#L307

in commit 5dd9e70 :+1:

See: https://ohbm.github.io/hackathon2020/hackathon/

Check if how the hub is presented seems OK to you :question: . If it is OK, and if this sounds OK to you :question: , then we will need to close this PR without being merged.

smoia commented 4 years ago

I'm sorry - I didn't see it!

Would it be possible to change the description in the website, like this:

details: "<a href="https://github.com/physiopy/phys2bids">Physiopy</a> is a github organisation that aims to offer open development solutions for physiology in MRI.
  <a href="https://github.com/physiopy/phys2bids">phys2bids</a> is the flagship library of physiopy, and it consists in a python3 library meant to format physiological
  (cardiac, respiratory, or gas signals) files in BIDS. <br>During this hackathon, we would love to involve new contributors to integrate new features, such as
  automatic recognition of the file content, support for eyetracking, and integration with other bidsificators (such as <a href="https://bidscoin.readthedocs.io">bidscoin</a>) 
  Next to phys2bids, we’re starting the development of phys2denoise, a library dedicated to prepare physiological signal for fMRI denoising.
  <br>More information <a href=https://github.com/ohbm/hackathon2020/issues/193>in this github issue</a>"

I modified it in this PR, but if it's not too much trouble to change it and it's more practical to change it someway else, better!

jhlegarreta commented 4 years ago

@smoia it's fine to modify it :+1:. However, the quotes in the hyper-links seem not to be supported by the system, e.g. <a href="https://github.com/physiopy/phys2bids">Physiopy</a> to <a href=https://github.com/physiopy/phys2bids>Physiopy</a>

and so on. Will you change them, please? Thanks !

jhlegarreta commented 4 years ago

@smoia thanks :tada: ! Tests are passing. Merging.

welcome[bot] commented 4 years ago

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! :tada: We here at OHBM Brainhack team really appreciate your contribution! :sparkling_heart: Go ahead and share your your first merge with your colleagues, you got yourself this brag right! :smile: :gift: