Speaker view in Panel page

RaphaelMeudec commented 2 years ago

This is ongoing work to add speakers info in the panel page. Let me know if you have some feedback on it? @rgbayrak @vborghe

Things I need to fix (add others if you have):

still some missing images/affiliations for some speakers
some images are not round, need to fix the ratio

Here is the preview:

vborghe commented 2 years ago

Awesome job, Raphael, thank you very much!

Maybe since we have now the card on canva you can use those instead of the single speakers images (here panel 1)? Less pretty but more efficient? As done here for the table talks. What do you think?

rgbayrak commented 2 years ago

We probably would prefer it to be clickable. There will be links to the speaker bio and pages. Static image is ok but not we want.

Roza

On Jun 1, 2022, at 12:28 PM, vborghesani @.***> wrote:

Awesome job, Raphael, thank you very much!

Maybe since we have now the card on canva you can use those instead of the single speakers images (here panel 1)? Less pretty but more efficient? As done here for the table talks. What do you think?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

rgbayrak commented 2 years ago

@RaphaelMeudec Looks good so far. In addition to the things you listed above,

we would like to highlight the roles in the panel, whether it is co-moderator or speaker, below the speaker photo as in here: https://ohbm.github.io/osr2022/volunteers/ Name, role (co-moderator or speaker), affiliation, link to pages.
If something is missing, it should not break the page instead, it just does not show.
Perhaps 3 people per row would make it look more tidy?

RaphaelMeudec commented 2 years ago

@vborghe @rgbayrak PR is ready for review, I added the twitter/github extra links, added the panel role and filled the missing affiliations. Here is an updated version of the visual:

vborghe commented 2 years ago

LGTM - thanks a lot, @RaphaelMeudec

vborghe commented 2 years ago

and it closes Panel Info Page #14, right?

RaphaelMeudec commented 2 years ago

Indeed, it closes #14, sorry for not adding it in the description (again)!

rgbayrak commented 2 years ago

After the merge, it hasn;t appeared on the page yet, I will close the issue once I confirm (checked multiple browsers and devices this time :/ I dunno what's up!).

Thank you @RaphaelMeudec! Snapshots look great!

ohbm / osr2022

Speaker view in Panel page #21