ohcnetwork / india-maps

Realtime map-based updates on COVID-19 cases in India using Ministry of Health and Family Welfare API
http://map.coronasafe.in/
MIT License
22 stars 21 forks source link

Added total hospitalized data on popup #2

Closed kpanuragh closed 4 years ago

gigincg commented 4 years ago

Hi Anuragh, thoughtful of you to add more information, we need all the help we can get.

First, I believe you're using some Auto-Linting Software which has formatted the code to it's specification in-effect changing a large majority of code which makes it difficult for me to review your changes. You could split the changes into 2 commits, First to complete the auto-linting and the changes you've proposed as a seperate commit. You may also avoid the Auto Linting and make a single commit with only your proposed changes.

Second, I believe your system date might be inaccurate which has dated the commit to 29th March 2020 which is 8 days ahead of today. Therefore merging this could possibly cause further issues down the lane, So I would request you to Close the PR and make a separate PR without these issues.

kpanuragh commented 4 years ago

okey