ohcnetwork / leaderboard

Leaderboard collects data from GitHub and Slack to show off the work of our open source contributors
https://contributors.ohc.network/
MIT License
18 stars 74 forks source link

While hovering over the badges of the contributors the UI is not theme aware. #516

Closed aswinmurali-io closed 1 month ago

aswinmurali-io commented 1 month ago

Enter your suggestions in details:

Make the UI theme aware because I see this as a dark UI component in light theme and dark theme mode both.

Light Theme

image

Dark Theme

image

Jash2606 commented 1 month ago

Hey @rithviknishad ,I'd like to contribute to this issue for Hacktoberfest . Could you please assign it to me?

dharmik3504 commented 1 month ago

Hello @rithviknishad , ,I'd like to contribute to this issue for Hacktoberfest . Could you please assign it to me?

rithviknishad commented 1 month ago

@dharmik3504 feel free to pick up other issues that are not assigned to anybody or ones that are assigned with no activity for more than a week.

Jash2606 commented 1 month ago

Hey @rithviknishad,

While setting up a repo, I'm encountering an issue when I click on people in the Contributors page. It's showing an error. Could you guide me on how to resolve this?

Screenshot 2024-10-01 113013

rithviknishad commented 1 month ago

Weird, we already have it exported.

image
Jash2606 commented 1 month ago

Weird, we already have it exported.

image

Should I try by changing it to default export?

rithviknishad commented 1 month ago

Try pulling the latest main branch now; fixed in: https://github.com/ohcnetwork/leaderboard/commit/8c3cae9119227bf2c5c9c469d6648ee9067d1947

dharmik3504 commented 1 month ago

Even i was facing same issue to resolve it i have just comment out the line no 56

Export const dynamicParams=false

And than loaded the contributor page onces and then i was able to access /contributor/slug page

rithviknishad commented 1 month ago

Thanks @dharmik3504 ;

Updated in: https://github.com/ohcnetwork/leaderboard/commit/f5c735c37e767f2d4c7bf93ea0ff95bd988a11c8

Jash2606 commented 1 month ago

Hey @rithviknishad , Can you review this preview for dark and light mode: Dark: Screenshot 2024-10-01 121255 Light: Screenshot 2024-10-01 121241

rithviknishad commented 1 month ago

Try white for the creative thinking section to add more contrast with the green and grey text.

Other than that LGTM

Jash2606 commented 1 month ago

Try white for the creative thinking section to add more contrast with the green and grey text.

Other than that LGTM

Hey @rithviknishad , Any other changes needed? image

rithviknishad commented 1 month ago

loos good to me

Jash2606 commented 1 month ago

Hey @rithviknishad , I had raised the PR #518 , Could you review it and Let me know if any changes required !