Duplicate PR collaboration activities

ohcnetwork / leaderboard

Leaderboard collects data from GitHub and Slack to show off the work of our open source contributors

https://contributors.ohc.network/

MIT License

18 stars 74 forks source link

Duplicate PR collaboration activities #531

Closed rithviknishad closed 2 weeks ago

rithviknishad commented 3 weeks ago

Currently activities such as "PR collaboration" may get duplicated when the default branch gets merged to another branch such as production/staging. This misjudges collaboration activities.

Proposed Solution

Exclude PR activities where the base branch is the non-default branch of the repository.

cc: @bodhish

VAIBHAVSING commented 3 weeks ago

/assign

VAIBHAVSING commented 3 weeks ago

@rithviknishad can you describe this issue in berif

rithviknishad commented 3 weeks ago

PR collaboration events should be tracked only for if the PR's base branch is the repository default branch

https://github.com/ohcnetwork/leaderboard/blob/6e38a436524cd71ca9a50cb51e84fe7a26564809/scraper/src/github-scraper/parseEvents.ts#L113-L120

VAIBHAVSING commented 3 weeks ago

@rithviknishad hello sir , I will not able to run scrapper can you assign to another person please.

rithviknishad commented 3 weeks ago

Are you facing any difficulties running the scraper?

VAIBHAVSING commented 3 weeks ago

@rithviknishad i will not able run scrapper after pasting github token in that

rithviknishad commented 3 weeks ago

here's the command to run the scraper

GITHUB_TOKEN=$(gh auth token) pnpm dev ohcnetwork ../data-repo/data/github

VAIBHAVSING commented 2 weeks ago

@rithviknishad can i completely ignore merge request from stagging or production branch or only ignore in above provided code at addcollaboration

rithviknishad commented 2 weeks ago

Didn't understand that, but whatever that was done in the PR is right.