search

ohcnetwork / leaderboard

Leaderboard collects data from GitHub and Slack to show off the work of our open source contributors
https://contributors.ohc.network/
MIT License
18 stars 74 forks source link

GitHub Scraper: Skip review events for PR authors #536

Closed rithviknishad closed 1 week ago

rithviknishad commented 1 week ago

Currently, review events are captured from the events API, and even follow-up comments made by PR authors are treated as review events.

When appending events for "pr_reviewed"; skip appending for those who are the author of the PR.

https://github.com/ohcnetwork/leaderboard/blob/f0dcce4be322ddd00db3842e64eec47785cecea0/scraper/src/github-scraper/parseEvents.ts#L204-L211

AnveshNalimela commented 1 week ago

@rithviknishad i would like on these issue But need some gudiance regarding the issue

rithviknishad commented 1 week ago

Sure, ask

Srayash commented 1 week ago

hey @rithviknishad, I've added a if statement which checks if the user and the PR author are same or not, and only appends pr_reviewed if they aren't same.