ohcnetwork / life

Verified Crowd-Sourced Emergency Services Directory
https://life.coronasafe.network/
85 stars 56 forks source link

Twitter is not searching for "Remdesivir, Tocilizumab etc." even Medicine is selected tab #228

Open technoknol opened 3 years ago

technoknol commented 3 years ago

Is your feature request related to a problem? Please describe. If I want to search for Remdesivir or Tocilizumab I'm unable to get it. Right now twitter query is searching for verified Oxygen, Ventilators and Bed even when I'm on medicine tab.

Describe the solution you'd like Medicine and All tab should search for Remdesivir or Tocilizumab or any other critical relative medicine.

Describe alternatives you've considered NA

Additional context NA

minkeshj commented 3 years ago

I believe this issue has been resolved already. We can close it. image

viksit commented 3 years ago

No this is not solved.

The way to solve this is,

n3jain commented 3 years ago

@viksit It looks like the covidConnect API for twitter search only supports two kinds of resource_type filtering 1. Supply 2. Demand. Also, the search string is constructed only from the location, doesn't take into the resource type or district. In order to make the twitter search appropriate based on the resource type and district, the updates need to be done for the covidconnect API. Could you please point to where the covid connect repository is, so that I can expand the feature set for that API?

brainless commented 3 years ago

@n3jain let me have a look at this today. @apoorvsingal and myself are in the covidconnect repo. If you have time right now then please feel free to make the changes, I can review the PR. The repo is at https://github.com/viksit/covidconnect

minkesh commented 3 years ago

@brainless @viksit I have raised the PR to integrate the changes done by @n3jain to support searching of medicines via covidconnect api. Now we have capability to search for required resources on twitter (previously it was a fixed hardcoded query).

minkeshj commented 3 years ago

Please review https://github.com/coronasafe/life/pull/268

viksit commented 3 years ago

Deployed