ohdearapp / ohdear-cli

The official Oh Dear CLI
https://ohdear.app
MIT License
134 stars 3 forks source link

Add homebrew formula #31

Closed olivernybroe closed 2 years ago

olivernybroe commented 2 years ago

Would be cool if the ohdear cli could be installed directly via homebrew for make it easier for non-php developers to use it.

owenvoke commented 2 years ago

👍đŸģ I've had this available for a while, however would be great to add it to the main tap. 🤘đŸģ Also, not sure how to cope with basically allowing depending on any version of PHP within a set (i.e. php or php@8.0), I guess once we've updated to PHP 8.1 this shouldn't be an issue (at least until PHP 8.2 releases).

https://github.com/owenvoke/homebrew-casks/blob/main/Formula/ohdear-cli.rb

freekmurze commented 2 years ago

Feel free to PR installation instructions for the brew version to the readme of this package 👍

owenvoke commented 2 years ago

Just went to PR it to the core repository, looks like it doesn't have enough stars, etc. on GitHub to be in the main repo. Oh well, I'll PR install instructions later.

freekmurze commented 2 years ago

How many stars would it need?

owenvoke commented 2 years ago

GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)

So probably not really feasible for now. 🤔

olivernybroe commented 2 years ago

Oh so not only stars, it also need watchers and forks 🤔

owenvoke commented 2 years ago

Looks like it only needs one of them? 🤔 https://github.com/Homebrew/brew/blob/55285e29b1e5d4497940539757cd576f47da68e5/Library/Homebrew/utils/shared_audits.rb#L96-L99

So 30+ forks OR 30+ watchers OR 75+ stars? But still, we're a way off on all of those unfortunately. ☚ī¸

freekmurze commented 2 years ago

I could try to get us to 75 stars. I'll tweet about it later today 🤞

owenvoke commented 2 years ago

https://github.com/Homebrew/homebrew-core/pull/102775 has been merged! GitHub Pages has just built a deployment and it's now live at https://formulae.brew.sh/formula/ohdear-cli 🤘đŸģ đŸĨŗ I've added install instructions to the README, and this issue can now be closed. 👍đŸģ

freekmurze commented 2 years ago

I tried it, but maybe I'm too early?

CleanShot 2022-06-06 at 11 25 49@2x
owenvoke commented 2 years ago

Try a brew update? 🤔

freekmurze commented 2 years ago

Should have tried that before 🙂

Added a note on this in the readme.