ohdsi-studies / Covid19PredictionStudies

Development and validation OHDSI network studies for the covid19 prediction topic
9 stars 9 forks source link

added "UPDATE STATISTICS" statement #4

Closed ssuvorov-fls closed 4 years ago

konstjar commented 4 years ago

This PR is required to handle Impala memory issues. The same change were added in (circle-be and SQLRender packages)

jreps commented 4 years ago

Thanks for the fix. I noticed this pull require made many changes to the sql scripts (I think due to extra EOL characters in addition to adding UPDATE STATISTICS). It is hard to review all the edits in the current pull request. Is it possible to edit the sql scripts in a way that only UPDATE STATISTICS is added (no other edits) - so I can quickly check that is the only change and then pull the requests?

konstjar commented 4 years ago

@jreps Thank you for checking. It looks like most of initial SQL files in master branch have strange "cr" as EOL. You can see it as red ^M

image

As a result when we clone master repo git transforms these EOL into additional line break. Is it possible to fix it in master branch?