search

ohdsi-studies / LegendT2dm

9 stars 15 forks source link

Add LegendT2dm to renv.lock #7

Open schuemie opened 2 years ago

schuemie commented 2 years ago

The current instructions assume the user has git installed, and knows how to clone a project. Worse still, the instructions don't mention that that is what the user is expected to do, causing confusion.

I recommend adding LegendT2dm to the renv lock file, and instruct users to download the lock file and initialize renv like this

msuchard commented 2 years ago

Point well taken! There's difficulties with the direct renv.lock download approach as well. Am working on this.

schuemie commented 2 years ago

Could you let me know what those difficulties are? I'm currently recommending the direct renv.lock download approach on the HADES site

rbcavanaugh commented 1 year ago

Not sure if it's helpful for an update here, but just in case this is useful for others. I'm helping install on a new AWS/windows workspace and the only way I can get it to install somewhat cleanly is to run the following in order. nloptr is problematic at the current version where there are no longer binaries. And without updating renv, I get constant installation errors at the restore() step and the build and install step. VM image includes R 4.1.2 by default and I haven't touched that - updating to 4.3.x seems to cause issues for MASS and a few other packages. 

install.packages("renv")
renv::activate()
renv::record("nloptr@2.0.3")
install.packages("nloptr")
renv::restore()
renv::upgrade()
renv::record("renv@1.0.2")
# use GUI to install & build