ohdsi-studies / PioneerWatchfulWaiting

This study is part of the joint PIONEER - EHDEN - OHDSI studyathon in March 2021, and aims to advance understanding of clinical management and outcomes of watchful waiting in prostate cancer.
Apache License 2.0
7 stars 18 forks source link

Use atlasName instead of name as cohortName #40

Closed MaximMoinat closed 3 years ago

MaximMoinat commented 3 years ago

This PR is both a fix for adding in the results the full name of the cohort instead of an id, and displaying old results with the full name. Fixes #39

MaximMoinat commented 3 years ago

@bdemeulder Please check whether this indeed solves the issue you reported

bdemeulder commented 3 years ago

Hi @MaximMoinat,

The changes in the global.R work, it now correctly displays the names of the cohorts.

But the changes you made in the cohort.csv file are not according to the phenotype tracker in MS teams (which is our source of truth, as far as I know.). Are those three additional phenotypes (28, 209, 210) necessary to display the results from task #3?

MaximMoinat commented 3 years ago

These phenotypes are also in Task 4, so I included them in again to render those nicely as well.