Fixes #94 by replacing function getCovariateDataSubset

ohdsi-studies / PioneerWatchfulWaiting

This study is part of the joint PIONEER - EHDEN - OHDSI studyathon in March 2021, and aims to advance understanding of clinical management and outcomes of watchful waiting in prostate cancer.

Apache License 2.0

7 stars 18 forks source link

Fixes #94 by replacing function getCovariateDataSubset #95

Closed MaximMoinat closed 3 years ago

MaximMoinat commented 3 years ago

Fixes #94.

Somehow the function getCovariateDataSubset was misbehaving. This function was used in two places, where I added the subsetting logic directly.

NOTE: this removes the ability to retrieve results from DB storage. As far as I know we were not using this anyway, as we read all premerged results from an .Rdata file.

MaximMoinat commented 3 years ago

@bdemeulder With the latest results data (9 data sources), I do still get warnings from data.tables. I think because of the sheer size of the data. But at least the issue of duplication of demographics data should be solved with this fix.

bdemeulder commented 3 years ago

I get the following error in the cohort characteriazation tab. The numbers have changed though, (from close to 60M rows down to 550K rows), so I guess your fix did that.

MaximMoinat commented 3 years ago

@bdemeulder Indeed. It seems there are two issues, one on the shiny side and one on the data side. This PR only fixed the shiny side of things