search

ohei / winff

Automatically exported from code.google.com/p/winff
0 stars 0 forks source link

preset name validation missing starting digit #181

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Edit -> Presets
2. Create a new preset with the name starting with a digit
3. Hit "Add / Update" and see winff report corruption:
"""
EDOMError in DOMDocument.CreateElement.

Press OK to ignore and risk data corruption.
Press Cancel to kill the program.
"""

What is the expected output? What do you see instead?
Proper message that preset names are not allowed to start with a digit.

According to [1]: """The element tags are case-sensitive; the beginning and end 
tags must match exactly. Tag names cannot contain any of the characters 
!"#$%&'()*+,/;<=>?@[\]^`{|}~, nor a space character, and cannot start with -, 
., or a numeric digit."""

[1] http://en.wikipedia.org/wiki/Xml#Well-formedness_and_error-handling

Original issue reported on code.google.com by poipodec...@hotmail.com on 1 Dec 2012 at 6:52

GoogleCodeExporter commented 8 years ago 
As I understand it, we agreed to do a major overhaul of the presets file, so 
this should be in scope for 1.6.

Original comment by poipodec...@hotmail.com on 16 Dec 2012 at 5:15