search

ohenley / awesome-ada

A curated list of awesome resources related to the Ada and SPARK programming language
Creative Commons Zero v1.0 Universal
627 stars 71 forks source link

Invisible logo on Firefox #97

Closed mgrojo closed 1 year ago

mgrojo commented 1 year ago

The new logo added in 43a355f34830214a7948ab04ba625178e26f2b42 cannot be displayed on Firefox browser.

ohenley commented 1 year ago

IMO, Firefox is definitely overrated. I will install Firefox and look into it. Thx @mgrojo.

mgrojo commented 1 year ago

It might be Firefox's fault, but also something not very standard compliant in the image. Look, for example, how it is displayed by the eog image viewer:

imagen

Both applications usually work well for SVG, but who knows. The W3C validator only raises two warnings, but one of them it's to warn about not analysing part of the file: https://validator.w3.org/check?uri=https%3A%2F%2Fraw.githubusercontent.com%2Fohenley%2Ffiles%2Fmaster%2Fawesome-ada%2Fawesome_ada_logo.svg&charset=%28detect+automatically%29&doctype=Inline&group=0

mgrojo commented 1 year ago

It's funny. In eog if you change the grid pattern by a black background, it displays correctly, with a white background it disappears completely. Firefox, on the other hand, behaves the same with a clear or a dark github theme.

ohenley commented 1 year ago

When I fix it for firefox, its chrome that can't show it.

ohenley commented 1 year ago

Fixed with https://vectr.com/. Try and confirm, please. Reload awesome-ada.

mgrojo commented 1 year ago

Yes, I can see it now. Good work!