search

ohenrik / bitfinex

A Python client for the Bitfinex API
MIT License
58 stars 32 forks source link

Start rest api v2 implementation #1

Closed dantimofte closed 6 years ago

dantimofte commented 6 years ago

add methods for Wallets,Orders,Orders History,Order Trades,Trades

ohenrik commented 6 years ago

Thank you for contributing, there are some things that should be improved, mostly related to python code style. you should consider using pylint integrated with your editor :)

I can make these changes, however it would be nice to have some way of verifying that i do not mess anything up. Due to a strange collision between pyOpenSSL, Twisted and HTTPpretty , the test do not work unless you uninstall pyOpenSSL before running the tests... I’ll create an issue for this. and maybe fix it by switching mocking library completely.

Do you have any code that you used during development that i can convert into tests? (you can send it to me over e-mail or just as a gist). Also if you want to try to add some tests your self feel free to do so.

To make the tests run just type:

pip uninstall pyOpenSSL
pytest -v

After you are done testing you can install pyOpenSSL again (needed by Twisted to run the websockets).