ohio813 / openid-selector

Automatically exported from code.google.com/p/openid-selector
0 stars 0 forks source link

Previous Url requested #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Click on Google (properly returns openid_identifier).
2. Click on Yahoo (returns the google openid_identifier instead of yahoo).
3. Click on Google (returns the yahoo openid_identifier instead of google).

What is the expected output? What do you see instead?

It gets out of sync after the first request. 

What version of the product are you using? On what operating system?

1.0 on FF3

Please provide any additional information below.

Not sure if this bug is only for non-username providers (Google, Yahoo) or 
if it applies to all providers. It appears related to using the cookie from 
the previous request, so something is out of sync.

Original issue reported on code.google.com by aaronsil...@gmail.com on 26 Dec 2008 at 5:28

GoogleCodeExporter commented 9 years ago
I'm having the same problem. I did some debugging and it changes the hidden
openid_identifier value twice when you sign in to a service. The first time is
correct and happens during the signin in routine. The second time it happens it 
uses
the prior value and that happens during the submit routine. Please fix this, as 
we
would like to use the code!

Original comment by tracy.gr...@gmail.com on 5 Jan 2009 at 3:31

GoogleCodeExporter commented 9 years ago
I am not the author but try this .js file I made a change that seems to work 
for me.

Brief fix details so you can modify your own if you like. 

In the signin function

signin: function(box_id, onload) {
 var provider = providers[box_id];
 if(!provider) {
  return;
 }
 this.highlight(box_id);
 this.setCookie(box_id);
 this.provider_url = provider['url']; // FIX IS HERE ADD THIS LINE
 if(provider['label']) {
  this.useInputBox(provider);
 } else { 
  this.setOpenIdUrl(provider['url']);
  if(!onload) {
   $('#openid_form').submit();
  }
 }
},
}

Original comment by mjezorek on 6 Jan 2009 at 11:24

Attachments:

GoogleCodeExporter commented 9 years ago
Gah I found another bug in that so that fix does not fix everything

Original comment by mjezorek on 6 Jan 2009 at 11:44

GoogleCodeExporter commented 9 years ago
where is the author andyjm????!!!

Original comment by tracy.gr...@gmail.com on 8 Jan 2009 at 4:07

GoogleCodeExporter commented 9 years ago
Not sure but I ended up rewriting it slightly. You can try this version however 
it 
will need a couple small mods in your html page.

I opened up the settings to overrides so you can change the providers shown if 
you 
want or anything thats in the settings. 

for example you can change to only use Google as a large image if you want 

$(document.ready(function() {
 $.openid({
  // your settings here
  img_path: '/images/',
  input_id: 'openid_identifier',
  providers_large: {
   google: {
    name: 'Google',
    url: 'http://ww.google.com/accounts/o8/id'
   }
  }
 });
});

I have not tested in all browsers but here is the begining of the rewrite. I 
may end 
up setting up a new project if the owner does not show up soon. Let me know if 
this 
does not work for you

Original comment by mjezorek on 8 Jan 2009 at 12:50

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed two small bugs in the previous upload.

Also there is a <div id="openid_error"></div> you can add to your html to get 
some 
basic error handling

Original comment by mjezorek on 8 Jan 2009 at 1:11

Attachments:

GoogleCodeExporter commented 9 years ago
Hi mjezorek,

That last version seems to be working. I didn't have to change the HTML, other 
than
to reference the new file name. Please upload your sample HTML if there are 
other
changes I should make.

Tracy

Original comment by tracy.gr...@gmail.com on 10 Jan 2009 at 3:51

GoogleCodeExporter commented 9 years ago
I will have to find it again the only change I made to the html that I remember 
is 
the addition of the <div id="openid_error"></div> which is only used in one 
case and 
thats when someone uses the OpenID large image and does not enter a value so it 
just 
puts a simple message in it saying please enter your open id. I will look for 
the 
sample I was using I just recently reformatted my PC to put windows 7 on it for 
some 
testing

Original comment by mjezorek on 12 Jan 2009 at 8:31

GoogleCodeExporter commented 9 years ago
I just rewrite this selector, now supports internacionalization and is smaller 
(js:
2.8k compressed, 4.7k full)

Since i couldn't contact the author i made another project:

http://code.google.com/p/openid-realselector/

Original comment by Refl...@gmail.com on 17 Jan 2009 at 9:10

GoogleCodeExporter commented 9 years ago

Original comment by david.j....@googlemail.com on 29 Apr 2009 at 9:02

GoogleCodeExporter commented 9 years ago

Original comment by david.j....@googlemail.com on 29 Apr 2009 at 1:40