Closed GoogleCodeExporter closed 9 years ago
sorry assigned the wrong type.should be an feature request.
Have created a sprite image and can help adjust the css.
first version is attached.
With more optimization the file gets smaller.
Original comment by b.wender...@gmail.com
on 11 Oct 2010 at 2:59
Attachments:
Thanks, this will be done in v1.3
For now please have a look at issue 19, v1.2 localization.
List of providers for each country might be different, for example it is
totally different for Russia and Ukraine, and might be different for France
(Orange as top-level provider), Korea and China, etc.
Thus we will need a sprite for each country, will have more details after
release of v1.2
Original comment by andriy.gerasika
on 11 Oct 2010 at 6:49
Doing sprites is difficult since not everybody uses the same OpenID providers.
Perhaps we can do a sprites version for those that want it if the basic example
is not good enough? Please don't make it the default. Thanks.
Original comment by and...@gmail.com
on 11 Oct 2010 at 6:30
The idea is to make a script that uses ffmpeg to generate image map
automatically.
i.e.
if you change list of providers you need to run a script that will regenerate
image map.
Original comment by andriy.gerasika
on 11 Oct 2010 at 7:38
yes, version w/ sprites won't be marked as "featured".
Original comment by andriy.gerasika
on 11 Oct 2010 at 7:53
done in SVN in branch 1.2
if provider list is changed, users should launch generate-imagemap.js -- this
will generate sprite using ImageMagick
Original comment by andriy.gerasika
on 12 Oct 2010 at 10:04
it is now configurable, set "openid.no_imagemap = true" to disable image maps
and use individual .gif files as in v1.1
Original comment by andriy.gerasika
on 12 Oct 2010 at 1:00
sounds great. will test it.
Original comment by b.wender...@gmail.com
on 12 Oct 2010 at 3:13
Original issue reported on code.google.com by
b.wender...@gmail.com
on 11 Oct 2010 at 12:47