ohitstom / spicetify-easyinstall

An open source GUI for installing Spicetify.
GNU Lesser General Public License v2.1
148 stars 4 forks source link

Revert "Implement GUI + more" #6

Closed ohitstom closed 2 years ago

ohitstom commented 2 years ago

Reverts ohitstom/spicetify-easyinstall#5

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.79%.

Quality metrics Before After Change
Complexity 5.66 ⭐ 10.15 🙂 4.49 👎
Method Length 68.75 🙂 70.32 🙂 1.57 👎
Working memory 8.78 🙂 8.51 🙂 -0.27 👍
Quality 65.71% 🙂 60.92% 🙂 -4.79% 👎
Other metrics Before After Change
Lines 1975 324 -1651
Changed files Quality Before Quality After Quality Change
Spicetify-Easyinstall.py 87.79% ⭐ 98.33% ⭐ 10.54% 👍
modules/core.py 38.64% 😞 42.06% 😞 3.42% 👍
modules/globals.py 92.78% ⭐ 99.00% ⭐ 6.22% 👍
modules/utils.py 76.39% ⭐ 77.45% ⭐ 1.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
modules/core.py install 23 😞 488 ⛔ 12 😞 26.73% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
modules/core.py update_addons 7 ⭐ 126 😞 9 🙂 60.80% 🙂 Try splitting into smaller methods
modules/utils.py find_config_entry 5 ⭐ 94 🙂 10 😞 64.87% 🙂 Extract out complex expressions
modules/utils.py list_config_available 6 ⭐ 70 🙂 10 😞 67.42% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!