ohitstom / spicetify-extensions

A repository for all my Spicetify extensions.
GNU General Public License v3.0
73 stars 2 forks source link

noControls.js not not working properly on macOS #22

Closed Ender-Wang closed 6 days ago

Ender-Wang commented 3 months ago

Can still saw a bit of it, btw I am also using a snippet "Remove top spacing". CleanShot_2024-09-01_14-37-40

ohitstom commented 3 months ago

uhm to be honest i didnt even think this would work for macos, unfortunately all im doing is telling spotify to set it to 0 i cant fundamentally change the cef display stuff........ you could maybe try running this in console and seeing if it works?

await Spicetify.CosmosAsync.post("sp://messages/v1/container/control", {
type: "update_titlebar",
height: "0px"
});
Ender-Wang commented 3 months ago

uhm to be honest i didnt even think this would work for macos, unfortunately all im doing is telling spotify to set it to 0 i cant fundamentally change the cef display stuff........ you could maybe try running this in console and seeing if it works?

await Spicetify.CosmosAsync.post("sp://messages/v1/container/control", {
type: "update_titlebar",
height: "0px"
});

Tried that but unfortunately, it does not work, also tried 0.1px, not working lmao. seems only 1px works, the other values are just not changing the position of it at all. Anyway, I did the other way around that added a small padding to the top of the left side bar:

#Desktop_LeftSidebar_Id{
  padding-top: 40px;
}

CleanShot_2024-09-02_09-06-16

Ender-Wang commented 6 days ago

@ohitstom Still seeing the traffic lights, seems the fix does not work. CleanShot_2024-11-25_18-20-01

ohitstom commented 6 days ago

@ohitstom Still seeing the traffic lights, seems the fix does not work. CleanShot_2024-11-25_18-20-01

might take a while to update on your end unless you can double check the code is identical

also make sure you are on latest Spotify :)

Ender-Wang commented 6 days ago

@ohitstom, I just saw it's updated in the marketplace and installed it, and my Spotify is on ver v1.2.45.454.gc16ec9f6 (the last version without the new search bar UI refresh).

Then I tried with the latest spotify ver : Spotify for macOS (Apple Silicon) 1.2.51.345.gcc39d911 Spicetify v2.38.4 It seems the extension does not work at all this time: CleanShot_2024-11-25_18-33-58

Edit: macOS 14.7.1 (23H222).

ohitstom commented 6 days ago

could you check inspect element console for relevant errors pls (the macos fix is only possible in latest Spotify because Spotify added new functionality it didn't previously have)

Ender-Wang commented 6 days ago

Test on two versions, procedure: new install noControl.js on marketplace, then saved the console log:

Here's the log on 1.2.45:

index.html:1 document.domain mutation is ignored because the surrounding agent cluster is origin-keyed.
(anonymous) @ index.html:1
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSpTitle-Black.woff2 net::ERR_NAME_NOT_RESOLVED
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSp-Book.woff2 net::ERR_NAME_NOT_RESOLVED
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSpTitle-Bold.woff2 net::ERR_NAME_NOT_RESOLVED
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSp-Bold.woff2 net::ERR_NAME_NOT_RESOLVED
spicetifyWrapper.js:453 [spicetifyWrapper] Waiting for required webpack modules to load
xpui.js:1 

       GET https://xpui.app.spotify.com/4151.css net::ERR_NAME_NOT_RESOLVED
l.F.miniCss @ xpui.js:1
(anonymous) @ xpui.js:1
l.E @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
favicon.ico:1 

       GET https://xpui.app.spotify.com/favicon.ico net::ERR_NAME_NOT_RESOLVED
spicetifyWrapper.js:474 [spicetifyWrapper] All required webpack modules loaded
extension.js:8 Initializing Spicetify Marketplace v1.0.2
extension.js:8 Loaded Marketplace extension
vendor~xpui.js:1 

       POST https://gew4-spclient.spotify.com/remote-config-resolver/v3/configuration 404 (Not Found)
x @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
(anonymous) @ vendor~xpui.js:1
_tick @ vendor~xpui.js:1
start @ vendor~xpui.js:1
_sendRetriedRequest @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
_sendRequest @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
_dispatchFromStore @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
a @ vendor~xpui.js:1
t @ vendor~xpui.js:1
postMessage
c @ vendor~xpui.js:1
emit @ vendor~xpui.js:1
_connectToEndpoints @ vendor~xpui.js:1
Promise.then
_performConnect @ vendor~xpui.js:1
_connect @ vendor~xpui.js:1
connect @ vendor~xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
resolveImpl @ xpui.js:1
resolve @ xpui.js:1
Hm @ xpui.js:1
await in Hm
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
94902 @ xpui.js:1
l @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
vendor~xpui.js:1 provider:transport resolve error k {url: 'https://gew4-spclient.spotify.com/remote-config-resolver/v3/configuration', status: 404, headers: P, body: {…}, offline: false, …} {}
h @ vendor~xpui.js:1
t.<computed> @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.catch
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
c @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
m @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
I @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
k @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
resolve @ vendor~xpui.js:1
Hm @ xpui.js:1
await in Hm
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
94902 @ xpui.js:1
l @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
index.html:1 Uncaught (in promise) k {url: 'https://gew4-spclient.spotify.com/remote-config-resolver/v3/configuration', status: 404, headers: P, body: {…}, offline: false, …}
Promise.then
(anonymous) @ vendor~xpui.js:1
a @ vendor~xpui.js:1
Promise.then
c @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
c @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
m @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
I @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
k @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
resolve @ vendor~xpui.js:1
Hm @ xpui.js:1
await in Hm
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
94902 @ xpui.js:1
l @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
5be84d93-584f-4e7b-bbc7-4fab232cfb0a:1 Uncaught DOMException: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'https://xpui.app.spotify.com/worker-css.js' failed to load.
    at blob:https://xpui.app.spotify.com/5be84d93-584f-4e7b-bbc7-4fab232cfb0a:1:1
(anonymous) @ 5be84d93-584f-4e7b-bbc7-4fab232cfb0a:1
index.html:1 The resource https://xpui.app.spotify.com/fonts/CircularSpTitle-Bold.woff2 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
index.html:1 The resource https://xpui.app.spotify.com/fonts/CircularSpTitle-Black.woff2 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
index.html:1 The resource https://xpui.app.spotify.com/fonts/CircularSp-Bold.woff2 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
index.html:1 The resource https://xpui.app.spotify.com/fonts/CircularSp-Book.woff2 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.

on latest 1.2.51:

index.html:1 document.domain mutation is ignored because the surrounding agent cluster is origin-keyed.
(anonymous) @ index.html:1
index.html:1 document.domain mutation is ignored because the surrounding agent cluster is origin-keyed.
(anonymous) @ index.html:1
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSp-Book.woff2 net::ERR_NAME_NOT_RESOLVED
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSpTitle-Bold.woff2 net::ERR_NAME_NOT_RESOLVED
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSp-Bold.woff2 net::ERR_NAME_NOT_RESOLVED
index.html:1 

       GET https://xpui.app.spotify.com/fonts/CircularSpTitle-Black.woff2 net::ERR_NAME_NOT_RESOLVED
spicetifyWrapper.js:453 [spicetifyWrapper] Waiting for required webpack modules to load
xpui.js:1 

       GET https://xpui.app.spotify.com/4151.css net::ERR_NAME_NOT_RESOLVED
l.F.miniCss @ xpui.js:1
(anonymous) @ xpui.js:1
l.E @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
favicon.ico:1 

       GET https://xpui.app.spotify.com/favicon.ico net::ERR_NAME_NOT_RESOLVED
spicetifyWrapper.js:474 [spicetifyWrapper] All required webpack modules loaded
extension.js:8 Initializing Spicetify Marketplace v1.0.2
sidebarConfig.js:169 Uncaught (in promise) TypeError: Spicetify.Snackbar?.enqueueCustomSnackbar is not a function
    at sidebarConfig.js:169:24
(anonymous) @ sidebarConfig.js:169
await in (anonymous)
SidebarConfig @ sidebarConfig.js:204
setTimeout
SidebarConfig @ sidebarConfig.js:3
setTimeout
SidebarConfig @ sidebarConfig.js:3
setTimeout
SidebarConfig @ sidebarConfig.js:3
(anonymous) @ sidebarConfig.js:296
extension.js:8 Loaded Marketplace extension
vendor~xpui.js:1 

       POST https://gew4-spclient.spotify.com/remote-config-resolver/v3/configuration 404 (Not Found)
U @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
(anonymous) @ vendor~xpui.js:1
_tick @ vendor~xpui.js:1
start @ vendor~xpui.js:1
_sendRetriedRequest @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
_sendRequest @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
_dispatchFromStore @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
a @ vendor~xpui.js:1
t @ vendor~xpui.js:1
postMessage
c @ vendor~xpui.js:1
emit @ vendor~xpui.js:1
_connectToEndpoints @ vendor~xpui.js:1
Promise.then
_performConnect @ vendor~xpui.js:1
_connect @ vendor~xpui.js:1
connect @ vendor~xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
resolveImpl @ xpui.js:1
resolve @ xpui.js:1
Ed @ xpui.js:1
await in Ed
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
92251 @ xpui.js:1
l @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
vendor~xpui.js:1 provider:transport resolve error k {url: 'https://gew4-spclient.spotify.com/remote-config-resolver/v3/configuration', status: 404, headers: L, body: {…}, offline: false, …} {}
h @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.catch
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
c @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
m @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
I @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
k @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
resolve @ vendor~xpui.js:1
Ed @ xpui.js:1
await in Ed
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
92251 @ xpui.js:1
l @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
index.html:1 Uncaught (in promise) k {url: 'https://gew4-spclient.spotify.com/remote-config-resolver/v3/configuration', status: 404, headers: L, body: {…}, offline: false, …}
Promise.then
(anonymous) @ vendor~xpui.js:1
a @ vendor~xpui.js:1
Promise.then
c @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
c @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
m @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
I @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
k @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
(anonymous) @ vendor~xpui.js:1
Promise.then
resolve @ vendor~xpui.js:1
Ed @ xpui.js:1
await in Ed
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
92251 @ xpui.js:1
l @ xpui.js:1
(anonymous) @ xpui.js:1
l.O @ xpui.js:1
(anonymous) @ xpui.js:1
(anonymous) @ xpui.js:1
e77ac361-cb48-4c14-9b57-512560aab374:1 Uncaught NetworkError: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'https://xpui.app.spotify.com/worker-css.js' failed to load.
    at e77ac361-cb48-4c14-9b57-512560aab374:1:1
(anonymous) @ e77ac361-cb48-4c14-9b57-512560aab374:1
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.