Closed fighterii closed 4 years ago
Merging #1205 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 43.61% 43.61%
=======================================
Files 32 32
Lines 3572 3572
Branches 580 580
=======================================
Hits 1558 1558
Misses 1872 1872
Partials 142 142
Impacted Files | Coverage Δ | |
---|---|---|
instabot/bot/bot.py | 77.17% <100%> (+0.04%) |
:arrow_up: |
instabot/api/api.py | 50.32% <100%> (-0.06%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 61cc977...7ec0037. Read the comment docs.
Thanks for great fix1
!!!
This PR should fix issue #1140 .
The api.logger is no longer overwritten by set_user method to a new logger without any handlers/formatters/loglevels.
Furthermore it extends the configuration option for logging by introducing two new arguments for API and Bot (loglevel_file and loglevel_stream).
The defaults are the old values (DEBUG for stream; INFO for file) to preserve existing behavior. In my opinion this doesnt make sense, I'd expect the default to be the other way round (less output in the console; more for debugging in the file), but for backwards compatibility I didn't change that.