Agoo dumps core on malformed SDL

jjw commented 2 years ago

Certain SDL syntax errors will cause Agoo to dump core

Reproduce on Ubuntu 20.02.4 LTS by downloading agoo/example/graphql/song.{rb,graphql} and run as follows

sed -i 's/!)/!/' song.graphql  # introduce syntax error in first line of Query by deleting closing parenthesis
ruby song.rb >log.txt 2>&1
Aborted

log.txt

Cheers, Jerry

ohler55 commented 2 years ago

I'll get it fixed. With luck, in the next couple of days.

ohler55 commented 2 years ago

Please try the fix-bad-sdl-crash branch.

ohler55 commented 2 years ago

Released. Thank for reporting the issue.

ohler55 commented 2 years ago

Can this be closed?

jjw commented 2 years ago

Sorry, should have said that I'm running the gem so I haven't been able to test by cloning the repo. I'll take your word for it though :-) so yes, please close.

Thanks, Jerry

On Mon, 28 Feb 2022 at 23:46, Peter Ohler @.***> wrote:

Can this be closed?

— Reply to this email directly, view it on GitHub https://github.com/ohler55/agoo/issues/107#issuecomment-1054822108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACEBD7TFJOPGOG6JUX2KLU5QCL7ANCNFSM5O6Y5QPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

ohler55 / agoo

Agoo dumps core on malformed SDL #107