search

ohler55 / ox

Ruby Optimized XML Parser
http://www.ohler.com/ox
MIT License
904 stars 76 forks source link

Autofix Rubocop Layout rules - Batch 3 #320

Closed nschonni closed 1 year ago

nschonni commented 1 year ago

Third run a the autofixing the Layout related Rubocop rules. Most of these have options allowing overriding specific things if they style isn't preffered.

nschonni commented 1 year ago

I manually changed the opening of the 2 ones you commented on, and then re-ran the format. That appears to get it back to the original you prefer without having to override the rule

ohler55 commented 1 year ago

Great, can you push those changes? I'll verify then approve..

nschonni commented 1 year ago

The change was pushed in the last commit

ohler55 commented 1 year ago

I still see [:end_element, :top],], AllSax, { :smart => true }) If you don't want to check the opening so that they all look good please keep the todo file and the originals for now.

nschonni commented 1 year ago

I removed 2 of the brace rules commits to get rid of most of the changes to sax_test.rb