search

ohler55 / wabur

Web Application Builder using Ruby
MIT License
48 stars 3 forks source link

Allow configuring Ruby runner JSON API indentation #138

Closed ashmaroli closed 7 years ago

ashmaroli commented 7 years ago

While it is already possible to configure indentation for JSON from OpO runners, Ruby runner wabur doesn't seem to support this functionality.

ohler55 commented 7 years ago

The question is, does it need to. Is there a reason to send formatted JSON or is tighter better since it is only a format for transfer.

ashmaroli commented 7 years ago

does it need to

It could be such that the JSON is tighter in production whereas in development, its pretty-formatted.. But having an option is always better.

If its possible in OpO based runners, it should be easily ported to Ruby runners as well, right?

ohler55 commented 7 years ago

Being an option in OpO does not make it easy, or harder to add to the Ruby runner. They are completely different. Having said that, it is not difficult to add to the Ruby runner either. Its more a matter of if we want to add it.

ashmaroli commented 7 years ago

:) I would like having such an option..

ohler55 commented 7 years ago

ok