search

ohlidalp / ror-toolkit

5 stars 4 forks source link

Hardcoded directory "Documents\Rigs of Rods 0.38" required for toolkit to start. #1

Closed ohlidalp closed 8 years ago

ohlidalp commented 8 years ago

* -- Reported by Aivar on RoR forums -- *

http://www.rigsofrods.com/threads/120839-RoRToolkit-is-coming-back-to-life?p=1390893&viewfull=1#post1390893

It seems that the toolkit looks for a \Documents\Rigs of Rods 0.38\ folder. If you have a different RoR version e.g. RoR 0.39.5, the user folder is called Rigs of Rods 0.39, so the cmd window closes without opening the toolkit because the aforementioned 0.38 folder isn't found.

The toolkit starts fine when the folder Rigs of Rods 0.39 in Documents is renamed to Rigs of Rods 0.38.

Perhaps it would be possible to add the option to manually select the user directory on startup?

ohlidalp commented 8 years ago

At the very least, RoRToolkit should report "Directory *\ not found, cannot start!"

I'll investigate why exactly does RoRToolkit need the RoR directory. Maybe the dependency can be removed altogether.

The toolkit also should be able to auto-detect RoR installation from windows registry.

ohlidalp commented 8 years ago

Yes, it's hardcoded allright: https://github.com/only-a-ptr/ror-toolkit/blob/lepes-r2-fusion/lib_common/ror/settingsManager.py#L164

If it's not present, RoRToolkit prints warning to console and continues execution happily until it crashes due to non-existent paths.

ohlidalp commented 8 years ago

Resolved in 021966208a47490a31c9e50599765f871e94243e Added homedir-selector to startup settings dialog.