search

ohmaddi / Portfolio-Kiva

Analyzing Kiva loans data from 2014
MIT License
0 stars 3 forks source link

Cam's Peer Review #2

Closed camkay closed 5 years ago

camkay commented 5 years ago

I really really liked your "Kiva at a Glance" visualization! Very masterful!

@datalorax

datalorax commented 5 years ago

Nice review, Cam!

I like that you added {here} syntax which, as you noted, can help with reproducibility.

Nice catch on the many-to-many join and it's great that you were able to fix it for her!

Ouafaa - I'd recommend trying to keep your syntax consistently within the tidyverse (or consistently within base). You're sort of going back and forth here a bit which can lead to some confusing code.

Really great review and nice work Ouafaa! Excited to see the end product.