ohmae / dms-explorer

DLNA Player for Android
MIT License
185 stars 32 forks source link

Added russian language #66

Closed FromSi closed 6 years ago

FromSi commented 6 years ago

When translating, there were minor problems, but I decided. Russian language is the second home for the Russian people. :ru: :)

codecov-io commented 6 years ago

Codecov Report

Merging #66 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #66   +/-   ##
=======================================
  Coverage     1.93%   1.93%           
=======================================
  Files          129     129           
  Lines         6052    6052           
  Branches       615     615           
=======================================
  Hits           117     117           
  Misses        5930    5930           
  Partials         5       5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f7e6d7...9d6dda4. Read the comment docs.

ohmae commented 6 years ago

Thanks! But I do not understand Russian at all... Can you tell me how to confirm? I do not even know the Russian title of language selection :sweat_smile: And can you tell me what is "minor problems"?

FromSi commented 6 years ago

All is well, but not perfect. =) The main thing is that now there is a Russian for Russian people :D

ohmae commented 6 years ago

I set like this. but display still English... screenshot_1532265100

FromSi commented 6 years ago

Did you add the "values-ru" folder? =)

ohmae commented 6 years ago

Yes, and cause turned out. Additional modification was necessary.

diff --git a/mobile/build.gradle b/mobile/build.gradle
index 0be8d98..ebfa261 100644
--- a/mobile/build.gradle
+++ b/mobile/build.gradle
@@ -18,7 +18,7 @@ android {
         targetSdkVersion 27
         versionCode versionMajor * 10000 + versionMinor * 100 + versionPatch
         versionName "${versionMajor}.${versionMinor}.${versionPatch}"
-        resConfigs "en", "ja"
+        resConfigs "en", "ja", "ru"
         vectorDrawables.useSupportLibrary = true
         buildConfigField "long", "BUILD_TIME", "${System.currentTimeMillis()}L"
     }
FromSi commented 6 years ago

good job :+1:

ohmae commented 6 years ago

This app was translated into Russian! Thanks! screenshot_1532266056

FromSi commented 6 years ago

Instead of "ON" you need to insert "ВКЛ". The text will look more beautiful. =)

ohmae commented 6 years ago

I did it. Is this OK? https://github.com/ohmae/DmsExplorer/commit/9199a6d96e1b301d815a909ac48ff45b4d65f2f3

FromSi commented 6 years ago

Ideally