ohmage / android

This is the repository for the ohmage Android application.
Apache License 2.0
7 stars 10 forks source link

leave ohmlet button behavior #81

Closed jshslsky closed 10 years ago

jshslsky commented 10 years ago

If I tap Leave ohmlet, the Join ohmlet dialog is presented. If I click Join, the underlying UI changes back to the Join UI and then ohmage crashes.

cketcham commented 10 years ago

this is because leaving an ohmlet is not a feature of 3.0. Until it is a feature though, the ohmlet activity should be short circuited to only ever try to join the ohmlet without any ui. (unless we want to add this feature before we give the app to users)

jshslsky commented 10 years ago

In the clinical use case, I don't think a researcher would ever want a user to leave an ohmlet, so we can leave it out of 3.0. If you short circuit the UI, will you just show the main screen instead?

cketcham commented 10 years ago

It will finish so quickly that it will basically never be shown (so whatever was behind it will continue to be shown). I'll just make a toast message or something that says they were added to the ohmlet, or they were already part of that ohmlet.