search

ohmage / gwt-front-end

The javascript/GWT code behind the front end.
6 stars 2 forks source link

Sign Out button click doesn't sign out user but takes it back to the Dashboard #267

Closed ctrance closed 11 years ago

ctrance commented 11 years ago

On browsers FF 18.0.1 & Safari 5.1.7/Windows 7, when I click Sign Out button I was taken back to the Dashboard instead of logging me out of the site.

stevenolen commented 11 years ago

The frontend is sometimes redirecting, and sometimes immediately creating an /app/whoami request. Log from server:

2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [DEBUG] [org.ohmage.request.RequestBuilder] - /app/user/logout
2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [INFO] [org.ohmage.request.UserRequest] - Creating a user request.
2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [INFO] [org.ohmage.request.auth.AuthTokenLogoutRequest] - Creating a logout request.
2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [INFO] [org.ohmage.request.auth.AuthTokenLogoutRequest] - Servicing the logout request.
2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [INFO] [org.ohmage.request.UserRequest] - Authenticating the user.
2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [INFO] [org.ohmage.request.auth.AuthTokenLogoutRequest] - Responding to the logout request.
2013-02-01 12:47:48,032 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [DEBUG] [org.ohmage.request.Request] - Returning a GZIPOutputStream
2013-02-01 12:47:48,033 [http-bio-8443-exec-19] [0ad8958d-4621-49dd-9bca-42a29b5dfc1d client=ohmage-gwt] [INFO] [org.ohmage.jee.servlet.RequestServlet] - Time to process '/app/user/logout':1
2013-02-01 12:47:48,266 [http-bio-8443-exec-9] [816f32c5-c225-452b-b225-0c417244ccdf client=ohmage-gwt] [DEBUG] [org.ohmage.request.RequestBuilder] - /app/user/whoami
2013-02-01 12:47:48,266 [http-bio-8443-exec-9] [816f32c5-c225-452b-b225-0c417244ccdf client=ohmage-gwt] [INFO] [org.ohmage.request.UserRequest] - Creating a user request.
2013-02-01 12:47:48,266 [http-bio-8443-exec-9] [816f32c5-c225-452b-b225-0c417244ccdf client=ohmage-gwt] [INFO] [org.ohmage.request.UserRequest] - org.ohmage.exception.ValidationException: The token cookie is unknown.
org.ohmage.exception.ValidationException: The token cookie is unknown.
    at org.ohmage.request.UserRequest.retrieveToken(UserRequest.java:565)
    at org.ohmage.request.UserRequest.<init>(UserRequest.java:104)
    at org.ohmage.request.auth.AuthTokenWhoAmIRequest.<init>(AuthTokenWhoAmIRequest.java:62)
    at org.ohmage.request.RequestBuilder.buildRequest(RequestBuilder.java:396)
    at org.ohmage.jee.servlet.RequestServlet.processRequest(RequestServlet.java:360)
    at org.ohmage.jee.servlet.RequestServlet.doPost(RequestServlet.java:329)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
    at org.ohmage.jee.servlet.RequestServlet.service(RequestServlet.java:236)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)        at org.ohmage.jee.filter.ClientFilter.doFilter(ClientFilter.java:167)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.ohmage.jee.filter.GzipFilter.doFilter(GzipFilter.java:109)        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.ohmage.jee.filter.Utf8RequestEncodingFilter.doFilter(Utf8RequestEncodingFilter.java:62)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.ohmage.jee.filter.Log4jNdcFilter.doFilter(Log4jNdcFilter.java:68)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at com.thetransactioncompany.cors.CORSFilter.doFilter(Unknown Source)
    at com.thetransactioncompany.cors.CORSFilter.doFilter(Unknown Source)        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:582)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:279)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)
jshslsky commented 11 years ago

(I updated your stack trace paste, Steve.) Can you describe the scenario in more detail? Did you login and log back out immediately or were you inactive for awhile, etc, etc?

stevenolen commented 11 years ago

Ah thanks. It happened to me sporadically, when logging in and nearly immediately logging back out. Perhaps once every four or so times?

stevenolen commented 11 years ago

When I sign in then leave the page alone for an extended period of time (long enough for my auth to expire), I cannot recreate this. To clarify, when I click sign-out after my auth has already expired, I am properly redirected to the login page.

ctrance commented 11 years ago

Just to clarify, I clicked Sign Out button before the auth's expiration and wasn't redirected to the login page but was taken to the dashboard page.

jshslsky commented 11 years ago

Fixed and deployed to test.ohmage.org.

stevenolen commented 11 years ago

While fixed when using chrome. I still experience this on otest with Firefox 18.0.2 and Safari 6.0.2 (latest of both).

stevenolen commented 11 years ago

Scratch that, still happened with chrome on my system as well :-/

jshslsky commented 11 years ago

Boooooooourns. :shit:

jshslsky commented 11 years ago

Please try again now. I tested on FF 16 and 18, Safari 6 and Chrome 24.

jojenki commented 11 years ago

It seems to be working for me.

stevenolen commented 11 years ago

yup, works for me. I'll close :). Thanks Josh!

ctrance commented 11 years ago

@joshuaselsky, @stevenolen, @jojenki, and @hongsudt - This issue still persists on my FF 18.0.2, it's been 40 secs since I clicked 'Sign Out' and nothing's happening so I just closed the browser to logout.

jshslsky commented 11 years ago

Everyone testing this please remember to clear you browser cache before re-testing. Thank you!

ctrance commented 11 years ago

@joshuaselsky - I cleared my cache and still having issue signing out on FF 18.0.2