search

ohmage / server

The ohmage server application.
37 stars 25 forks source link

Error 500 when not logged in #863

Closed jeroen closed 9 years ago

jeroen commented 9 years ago

There is a recent bug in Ohmage that results in a HTTP 500 error when calling the API while not logged in.

To reproduce: make sure you are not logged in and navigate to https://test.mobilizingcs.org/#campaign_mgmt/.

hongsudt commented 9 years ago

Why would you call the server when u r not logged in? On Aug 31, 2015 7:57 AM, "Jeroen Ooms" notifications@github.com wrote:

Assigned #863 https://github.com/ohmage/server/issues/863 to @hongsudt https://github.com/hongsudt.

— Reply to this email directly or view it on GitHub https://github.com/ohmage/server/issues/863#event-396752769.

jeroen commented 9 years ago

Because you don't know you're not logged in, or the session timed out, or you used a hyperlink to navigate to an application that assumes you're logged in, or whatever. The server should be responding with an ohmage error code "0200" when the session is no longer valid so that the client knows he has to redirect to the login page. This always worked until recently.

jeroen commented 9 years ago

The laud server does not have this problem so it must be introduced recently.

hongsudt commented 9 years ago

I know.. I checked this last night. I will look into this further today.

On Tue, Sep 1, 2015 at 5:49 AM, Jeroen Ooms notifications@github.com wrote:

The laud server does not have this problem so it must be introduced recently.

— Reply to this email directly or view it on GitHub https://github.com/ohmage/server/issues/863#issuecomment-136704707.

hongsudt commented 9 years ago

resolved with commit b4f4804

jeroen commented 9 years ago

Thanks for fixing