ohmeow / blurr

A library that integrates huggingface transformers with the world of fastai, giving fastai devs everything they need to train, evaluate, and deploy transformer specific models.
https://ohmeow.github.io/blurr
Apache License 2.0
289 stars 34 forks source link

Installing Blurr Breaks Kaggle Notebook Saving #57

Closed warner-benjamin closed 2 years ago

warner-benjamin commented 2 years ago

Installing blurr in a Kaggle notebook breaks saving the notebook due incompatible nbconvert requirements. Kaggle requires nbconvert-6.1.0, but blurr installs nbconvert-5.6.1.

This appears to be due to blurr requiring nbverbose as a install requirement. A possible fix on blurr's end could be moving nbverbose to dev_requirements until nbdev has it's dependencies updated.

The dependency tree, from pipdeptree:

- ohmeow-blurr==0.1.0 [requires: nbverbose>=0.0.1] 
   - nbverbose==0.0.9 [requires: nbdev<2.0.0]
      - nbdev==1.1.23 [requires: nbconvert<6]
ohmeow commented 2 years ago

OK let me take a look, I'll try to get a new release out in a bit.

On Thu, Nov 18, 2021, 8:59 AM Benjamin Warner @.***> wrote:

Installing blurr in a Kaggle notebook breaks saving the notebook due incompatible nbconvert requirements https://www.kaggle.com/product-feedback/284575#1587164. Kaggle requires nbconvert-6.1.0, but blurr installs nbconvert-5.6.1.

This appears to be due to blurr requiring nbverbose as a install requirement https://github.com/ohmeow/blurr/blob/5175f13202cb714f1b4fe3309fbbd8afcb039059/settings.ini#L18. A possible fix on blurr's end could be moving nbverbose to dev_requirements until nbdev has it's dependencies updated.

The dependency tree, from pipdeptree https://github.com/naiquevin/pipdeptree:

  • ohmeow-blurr==0.1.0 [requires: nbverbose>=0.0.1]
    • nbverbose==0.0.9 [requires: nbdev<2.0.0]
      • nbdev==1.1.23 [requires: nbconvert<6]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ohmeow/blurr/issues/57, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADNMHGYQN4KBPO5YWEXELUMUWIBANCNFSM5IKDRMWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ohmeow commented 2 years ago

Ok just release new version ... 0.1.1

Give it a go and lmk if it works with kaggle, and if so, feel free to close this issue out.

warner-benjamin commented 2 years ago

Works fine on kaggle now. Thanks.

ohmeow commented 2 years ago

Good deal! Lmk how your project goes (and if you get a notebook up, I'd love to see it)

warner-benjamin commented 2 years ago

@ohmeow you might need to update the github workflow to install a dev editable install pip install -qe .[dev] for nbdev_test_nbs to work