ohmg-dev / OldInsuranceMaps

A public space for georeferencing historical fire insurance maps.
https://oldinsurancemaps.net
GNU General Public License v3.0
17 stars 2 forks source link

Classify layer as Key Map does not save succesfully #178

Closed rchampine closed 1 week ago

rchampine commented 4 months ago

I'm not sure if this is just on this map or others as well, but the Classify Layers function is not behaving correctly for saving a Key Map. It appears to work, but upon refreshing or opening up a georeferencing session, the classified sheet reverts back to Main Content.

https://github.com/mradamcox/ohmg/assets/136510277/3e28346f-2921-45c5-a81d-6117ae3728ad

mradamcox commented 4 months ago

Thanks @rchampine, I think I see the problem, should be able to deploy a fix later tonight (as well as some a few other updates).

rchampine commented 4 months ago

Great — thank you!

rchampine commented 2 months ago

Looks like this issue or a very similar issue is cropping up again.

https://github.com/ohmg-dev/OldInsuranceMaps/assets/136510277/fd9b9ce6-9edd-435e-95d1-47dde8b26866

rchampine commented 2 months ago

Additional example on this Philadelphia volume where a map is "stuck" as classified as a Key map: https://oldinsurancemaps.net/resource/32830

image
mradamcox commented 2 months ago

Weirdly, I was able to just go in and classify this one properly right now. There must be some intermittent issue having to do with the state of the page. Definitely warrants investigation. I wonder if a full page reload is needed in between classification/reclassification of the same item?

rchampine commented 2 months ago

Interesting... I'm having no luck with reloading and classifying on either of these volumes: https://oldinsurancemaps.net/map/sanborn04023_022 https://oldinsurancemaps.net/map/sanborn06671_013

mradamcox commented 2 months ago

Huh, and again, worked fine for me. Things are a little jumpy sometimes though, like I set to Key Map and it flashed back a forth once or twice and then settles. One thing to note is that the save happens immediately on the dropdown change, not when the Done button is clicked. At any rate, will look further soon.

rchampine commented 2 months ago

This volume is also experiencing the bug for both Nate and I — https://oldinsurancemaps.net/map/sanborn09345_008

mradamcox commented 2 months ago

So strange. At first it didn't work for me and now it just did. At any rate, I've reworked this classification process a bit locally, just haven't been able to deploy the changes yet. Perhaps tonight or early tomorrow morning.

rchampine commented 2 months ago

Great — thank you!

mradamcox commented 2 months ago

Ok, I've reworked the process a bit, so the Save/Cancel buttons are implemented again, and the logic that handles the process is a bit cleaner. I think this particular issue should be addressed, though there are still some details to come back to.

rchampine commented 2 months ago

Is this implemented publicly? I'm still seeing the same behavior/bug as before.

mradamcox commented 2 months ago

:facepalm: Ok now it is.

rchampine commented 2 months ago

Yes! Haha thank you.