ohmjs / ohm-editor

An IDE for the Ohm language (JavaScript edition)
MIT License
96 stars 17 forks source link

Expand emoji support in "Explain Parse" preview #52

Open s-gbz opened 2 years ago

s-gbz commented 2 years ago

A note of gratitude

Hey there! First of all: Thanks a lot for your continuous effort in developing Ohm & the Ohm-Editor. It's much much appreciated and will most likely be a backstone in my emoji driven programming language (& master's thesis).

Feature suggestion

Regarding the issue's title: Have you considered expanding the preview's emoji support? The tree leaves seem to allow the browser to display emojis natively. The "overview" doesn't seem to parse the unicode correctly tough.

I haven't looked into the code yet, however I expect it to be a rather quick fix/ adaption.

image

Call to action

Is this issue something you might consider worthwhile? Is this sth. you might want to tackle? Are there any pointers you could give me to look into the code myself? I can't make any promises since I myself don't prioritize this issue that much, but "the long winter nights" are coming - who knows!

Thanks again and best regards from Bochum, Ruhr Valley ;)

pdubroy commented 2 years ago

Hi Sergej! First off, I appreciate the thank-you note! I started working on this project as part of my work, but for the past four years it's all been done in my free time, so it's really nice to hear something like this.

To answer your questions:

s-gbz commented 2 years ago

Hey there @pdubroy just wanted to give you a little heads up that I've started looking into the editor's code. There're a couple small adjustments I hacked in my own fork and I will definitely provide some PRs with issues. However, that might take a while, because I'm too heel over head in other projects.

Anyways, thanks for the pointer and see you soon!