search

ohmjs / ohm

A library and language for building parsers, interpreters, compilers, etc.
MIT License
5.01k stars 217 forks source link

Issues with "Ohm: Parsing Made Easy" article #338

Closed customcommander closed 3 years ago

customcommander commented 3 years ago

Hi,

Re: https://nextjournal.com/dubroy/ohm-parsing-made-easy

First I want to say that this article is amazing. It got me super excited to trying out Ohm!

As I was reading through I noticed a couple of things:

Broken code runner?

This is just one example:

Screenshot 2021-11-16 at 09 59 19

Repeated list items Screenshot 2021-11-16 at 09 59 57

Repeat list items + one dead link

Screenshot 2021-11-16 at 10 00 38

pdubroy commented 3 years ago

Thanks for letting me know, and I appreciate the super clear bug report :-)

I've fixed up the duplicated content and the broken link. However, the ohm:nil thing is something specific to Nextjournal that I don't know how to resolved. I've emailed the team, hopefully they can tell me how to fix it.

customcommander commented 3 years ago

@pdubroy Looks like they fixed the nil issue. Thanks for fixing so quickly!

pdubroy commented 3 years ago

Cool! Thanks go to @mk and crew for the quick fix on Nextjournal :-)

mk commented 3 years ago

Oh yes, @zampino fixed it promptly and I said I’d write you @pdubroy but then forgot. 🙈 Sorry for breaking it in the first place!