search

ohmjs / ohm

A library and language for building parsers, interpreters, compilers, etc.
MIT License
5.01k stars 217 forks source link

Fix issues with Node.isOptional() typings #374

Closed zsakowitz closed 2 years ago

zsakowitz commented 2 years ago

Currently, Node.isOptional is a function returning a boolean, but the typings show it as a property, not a method. Changing it to a method would help many TypeScript users, and I'm running into issues using this function myself.

pdubroy commented 2 years ago

I've just published v16.3.3 containing this fix.

zsakowitz commented 2 years ago

Thank you!

zsakowitz commented 2 years ago

I just tried to download the latest version (v16.3.3) and it doesn't have the fix. Can you double-check that you've uploaded it?

pdubroy commented 2 years ago

My bad. I forgot that this file is generated from index.d.ts.template — so as soon as I ran the release, it overwrote the changes. I just landed a proper fix and did a new release (v16.3.4).

Thanks for pointing out the mistake!

zsakowitz commented 2 years ago

Oops. Sorry about that! Thanks for patching it properly and being so quick to respond.