search

ohmstance / trilium-lightpad-theme

My personal Trilium theme, named Lightpad.
MIT License
45 stars 1 forks source link

Install inop #3

Closed doobes closed 2 weeks ago

doobes commented 3 months ago

Went through the procedure. Doesn't show up in themes list.

None of the imported notes have any imported attributes.

Both .js files replete with code errors

doobes commented 3 months ago

**I added "#appTheme=Lightpad " as an Owned Attribute to Lightpad.css, and it appeared in the theme selection.

Both js files displaying multiple errors.**

ohmstance commented 3 months ago

Weird. Just to verify, you are importing the theme zip file in the releases page, right? https://github.com/ohmstance/trilium-lightpad-theme/releases/tag/v20240330

Each note should have the following attribute:

Is this a Trilium server instance? What browser are you using Trilium with?

doobes commented 3 months ago

Ok,

No, I had downloaded using the code button. I had to search the page to find the "Releases" selection over on the right hand side. Yours is one of the few themes that make us of that.

I've got a server install, a Windows native install and a Linux native install.

I access the server install from Android devices (A Pixel 3A XL phone, and a Samsung Galaxy Tab 4 tablet) using Firefox (for now at least. Firefox has a battery consumption issue at present, and if it doesn't get resolved soon, I'll switch to another browser).

My phone and tablet don't demonstrate js code errors. Everything else does:

Linux native

Trilium Linux LaunchPad

Linux Firefox

Trilium Linux LaunchPad Firefox

Windows native

Trilium Windows LaunchPad

My phone version will close Firefox after about 90 seconds. Tablet version doesn't exhibit this.

Thanks for responding.

ohmstance commented 3 months ago

That is to be expected as Trilium uses ESLint 5 for code linting which by default parses JS ES5 syntax. The let declaration is introduced with ES6 (2015). Oh and I don’t think the mobile frontend supports code linting, hence the absence of error.

ESLint can lint newer ECMAScript syntax but that requires a change to Trilium's ESLint config here to ecmaVersion: 2019 (latest supported by ESLint 5.11.1).

Just ignore the error.