search

ohmtech-rdi / eurorack-blocks

Software to Hardware Prototyping for Eurorack using C++, Max/Gen~ or Faust
Other
314 stars 21 forks source link

Fix faust memory create #464

Closed ohmtech-rdi closed 1 year ago

ohmtech-rdi commented 2 years ago

Fix missing internal buffers allocation by calling memoryCreate before the DSP instance is inited, following the documentation on the new -mem option.

The memoryCreate function is a new function, but which must be called, in order for the DSP to correctly instantiate.

To keep compatibility with pre-2.41, we are checking whether the function exists or not at build time and call it if available.

ohmtech-rdi commented 1 year ago

@jazamatronic Please evaluate

jazamatronic commented 1 year ago

G'day @ohmtech-rdi I'm new to github reviews, I hope I've done the right thing. In any case it looks good. Let me know if you need anything else.

ohmtech-rdi commented 1 year ago

Hi @jazamatronic You did right! Thanks a lot for your review.