search

ohmtech-rdi / eurorack-blocks

Software to Hardware Prototyping for Eurorack using C++, Max/Gen~ or Faust
Other
303 stars 21 forks source link

Fix shift register timings #488

Closed ohmtech-rdi closed 1 year ago

ohmtech-rdi commented 1 year ago

This PR fixes a bug where reading BX was wrong. Basically having an input high would influence slightly the next reading.

This bug is quite rare and occurred on some boards we tested with the upcoming Kivu12 development board.

We solved it by increasing the number of ticks between the shift register state change. After quite some back and forth, it seems to properly solve the problem.

Incidentally, that also seems to reflect the timing libDaisy was using before making a refactor, which potentially introduced wrong timings. here is the older version.