ohmtech-rdi / eurorack-blocks

Software to Hardware Prototyping for Eurorack using C++, Max/Gen~ or Faust
Other
309 stars 21 forks source link

Setup: use ssl certificate for download #580

Closed eliottparis closed 1 year ago

eliottparis commented 1 year ago

This PR makes sure we don't have ssl certificate issues while downloading files during erbb setup. For that, the Latest CA bundles is included in this repository and used to craft our SSL context for download.

Fixes #563.

Note: On PR #578, there may still be issues while downloading the certificate bundles file from https://mkcert.org; that's why it was decided to include this file in the repository. Note that some certificates can expire so we will need to update this file from time to time.

Todo:

ohmtech-rdi commented 1 year ago

As for expiring certificates, I found that for us that should be first time in 2029:

pypi.org and files.pythonhosted.org
GlobalSign Root CA - R3
Expires: Sunday 18 March 2029 
the certificate is valid for 20 years.

Same CA for developer.arm.com.

github.com
DigiCert Global Root CA
Expires: Monday 10 November 2031
(25 years)
ohmtech-rdi commented 1 year ago

I would say let's first check on our repro, then test on fresh installs and call it a day.