todos - Githubissues

ohmybash / oh-my-bash

A delightful community-driven framework for managing your bash configuration, and an auto-update tool so that makes it easy to keep up with the latest updates from the community.

https://ohmybash.github.io

MIT License

5.59k stars 628 forks source link

todos #272

Open akinomyoga opened 2 years ago

akinomyoga commented 2 years ago

This is the todo list.

[ ] Check old issues related to the maintenance policy. Ask questions or open discussions if necessary.
- [x] changes to CONTRIBUTING.md #269
- [ ] #90 Will revisit after #269 settled.
[x] Check all the pull requests
Fix bugs of oh-my-bash.sh. E.g.
- [x] ${...:t} has a different meaning in Bash, -> #166
- [x] fpath=(xxxx $fpath) doesn't work in Bash. Also, there is no alternative for Zsh fpath in Bash. #274
- [ ] PROMPT (set by standard.theme and dos.theme) should not be enclosed by \[...\]. To begin with, these themes should set PS1 instead of PROMPT.
- [ ] Configuration for PREVIEW should be moved to lib or plugin although I'm not sure what this settings is for.
[ ] Process small pull requests. I have reviewed almost all of the existing PRs. Wait and see if there is any response to the comments.
[ ] Process large PRs
- [x] #73 in progress
- [ ] #270
Make the coding style consistent
- [ ] Create documents
- [ ] delete trailing spaces
- [ ] consistent indentation
- [ ] func() vs function func etc.
- cf https://github.com/ohmybash/oh-my-bash/issues/211#issuecomment-1217212138
- cf https://github.com/ohmybash/oh-my-bash/issues/307#issuecomment-1043582147
- cf https://github.com/ohmybash/oh-my-bash/issues/364#issuecomment-1262246594
- cf https://github.com/ohmybash/oh-my-bash/issues/395#issuecomment-1424348432
- Fix: 59f6ef145bbfb0e8216566d25c07299931a4c491
- We still see divergence between function name { vs function name() {.
- [ ] [ ... ] vs [[ ... ]], quoting inside, == vs =
- [ ] declare and typeset in function scopes
- [ ] Missing locals
- [ ] set -u
- [ ] set -f
[ ] Summarize the upstream repositories of plugins/themes in Wiki or documents
- [ ] Update and merge the changes. Submit PRs to upstream if necessary or applicable
- [ ] completions/git.completion.sh #277 thanks to @jeansebastienh
- [ ] tools/git-prompt.sh
- [ ] Themes seem to be from Bash-it. cf https://github.com/Bash-it/bash-it/pull/1741 and https://github.com/Bash-it/bash-it/pull/1752
- [ ] Check the copyright of the upstream. We also need to update the copyright notice in README. Not every code in oh-my-bash can be distributed under the MIT license.
[ ] Check conflicting aliases
[x] Conflicting variables in lib/util.sh and themes/colours.theme.sh -> namespacing
[ ] Summarize all the configuration variables OSH_* and OMB_* used by plugins and themes.
[ ] Why not use bash-completion but define a limited number of completions on its own?
- bash-completion seems like automatically loaded in lib/bourne-shell.sh
[ ] install: Bash version is checked inside the installation script, but the installation script and the interactive shell are not necessarily the same.
[ ] Avoid aliases by command awk, command sed, command grep, etc.
[x] OMB_VERSION, --version for install.sh, omb, etc.
PROMPT_COMMAND
- [x] Use _omb_util_add_prompt_command instead of directly assigning a value to PROMPT_COMMAND.
- [x] Allow reloading (related to 028d2537392a5e1ec8166600105840e107eb65c9). We need to modify _omb_util_add_prompt_command
- [ ] Check compatibility with bash-preexec. (ref #195)
[ ] IFS=$OLD_IFS etc causes problems when IFS is originally unset.
[ ] Maybe it is better that we only enable battery in themes when plugin:battery is loaded. Related #220, #286.
[x] Check all occurrences of $arr[...]
[x] _omb_module_require does not check already-loaded files though we implicitly assume that in some places.
[x] egrep, fgrep deprecated by POSIX

akinomyoga commented 1 year ago

Issues

[ ] The themes axin, binaryanomaly, and sexy are overwriting TERM, which is unusual. It seems to be used to force the later calls of tput to recognize 256 colors.